Skip to content

chore: consolidate workspace settings [MSRV 1.64+] #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: consolidate workspace settings [MSRV 1.64+] #4406

wants to merge 1 commit into from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 14, 2025 •
edited
Loading

  • Move common workspace settings to the [workspace] sections in the root.
  • Add common clippy lint configuration

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added ctest Issues relating to the ctest crate S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 14, 2025
@rustbot rustbot added the A-CI Area: CI-related items label Apr 14, 2025
tgross35
tgross35 requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to do a MSRV bump at this time - is this required?

The other cleanup looks good but I'd rather defer anything that doesn't work in 1.63.

@nyurik
Copy link
Contributor Author

nyurik commented Apr 14, 2025

@tgross35 sadly we can't use workspace settings inheritence until 1.64, which stabilized workspace-inheritance :(

@tgross35
Copy link
Contributor

Ah, I was thinking it worked for some fields before then. We can land changes that don't depend on that like removing build = "build.rs", but organization improvements in this repo aren't enough to justify a user-facing new MSRV. We'll likely be bumping it sometime later this year, but until then

@rustbot blocked

@nyurik nyurik mentioned this pull request Apr 14, 2025
Merged
@nyurik
Copy link
Contributor Author

nyurik commented Apr 14, 2025

@tgross35 thx, I created a #4408 for that

@nyurik nyurik changed the title chore: consolidate workspace settings chore: consolidate workspace settings [MSRV bump!] Apr 14, 2025
@nyurik nyurik changed the title chore: consolidate workspace settings [MSRV bump!] chore: consolidate workspace settings [MSRV 1.64+] Apr 14, 2025
@nyurik nyurik force-pushed the workspace branch 2 times, most recently from 2872a7a to 637f11f Compare April 15, 2025 05:33
@nyurik
chore: rework workspace params, MSRV 1.64
8e814d0 
* Move common workspace settings to the `[workspace]` sections in the root.
* Remove Cargo settings that are identical to the defaults (per Cargo [recommendations](https://doc.rust-lang.org/cargo/reference/manifest.html))
* Add common clippy lint configuration
* These require MSRV 1.64 `workspace-inheritance` feature
* Fix perl-based method to extract MSRV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tgross35 tgross35

Labels
A-CI Area: CI-related items ctest Issues relating to the ctest crate S-blocked stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyurik @rustbot @tgross35